[SPARK-24891][SQL] Fix HandleNullInputsForUDF rule #21851
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gatorsmile
reviewed
Jul 23, 2018
| // branch of `If` will be called if any of these checked inputs is null. Thus we can | ||
| // prevent this rule from being applied repeatedly. | ||
| val newInputs = parameterTypes.zip(inputs).map{ case (cls, expr) => | ||
| if (needsNullCheck(cls, expr)) AssertNotNull(expr) else expr } |
There was a problem hiding this comment.
Let us introduce KnownNotNull instead of using AssertNotNull, which has a side-effect?
|
Test build #93459 has finished for PR 21851 at commit
|
|
Test build #93469 has finished for PR 21851 at commit
|
|
retest this please |
|
update the PR description? |
|
Test build #93503 has finished for PR 21851 at commit
|
|
retest this please |
|
Test build #93514 has finished for PR 21851 at commit
|
|
LGTM Thanks! Merged to master/2.3 |
asfgit
pushed a commit
that referenced
this pull request
Jul 25, 2018
The HandleNullInputsForUDF would always add a new `If` node every time it is applied. That would cause a difference between the same plan being analyzed once and being analyzed twice (or more), thus raising issues like plan not matched in the cache manager. The solution is to mark the arguments as null-checked, which is to add a "KnownNotNull" node above those arguments, when adding the UDF under an `If` node, because clearly the UDF will not be called when any of those arguments is null. Add new tests under sql/UDFSuite and AnalysisSuite. Author: maryannxue <[email protected]> Closes #21851 from maryannxue/spark-24891.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
The HandleNullInputsForUDF would always add a new
Ifnode every time it is applied. That would cause a difference between the same plan being analyzed once and being analyzed twice (or more), thus raising issues like plan not matched in the cache manager. The solution is to mark the arguments as null-checked, which is to add a "KnownNotNull" node above those arguments, when adding the UDF under anIfnode, because clearly the UDF will not be called when any of those arguments is null.How was this patch tested?
Add new tests under sql/UDFSuite and AnalysisSuite.